Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add dark mode to storybook #10286

Merged
merged 14 commits into from
Sep 3, 2024
Merged

fix: Add dark mode to storybook #10286

merged 14 commits into from
Sep 3, 2024
+111 −10

Conversation

brianacnguyen
Copy link
Contributor

Description

This PR adds dark mode OS toggle on storybook

Related issues

Fixes: #8683

Manual testing steps

  1. Go to storybook
  2. View any component
  3. Toggle appearance on emulator

Screenshots/Recordings

Before

After

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-11.at.10.48.52.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Jul 11, 2024
@brianacnguyen brianacnguyen self-assigned this Jul 11, 2024
@brianacnguyen brianacnguyen requested review from a team as code owners July 11, 2024 17:51
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

georgewrmarshall
georgewrmarshall reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left one question regarding where the ThemeProvider lives

app/component-library/providers/ThemeProvider.tsx Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.62%. Comparing base (4b9f31c) to head (7243880).
Report is 27 commits behind head on main.

Files Patch % Lines
app/component-library/providers/ThemeProvider.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10286      +/-   ##
==========================================
- Coverage   49.78%   49.62%   -0.17%     
==========================================
  Files        1437     1463      +26     
  Lines       34762    35376     +614     
  Branches     3921     4030     +109     
==========================================
+ Hits        17307    17554     +247     
- Misses      16354    16713     +359     
- Partials     1101     1109       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianacnguyen brianacnguyen removed the request for review from wachunei August 12, 2024 21:26
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@brianacnguyen brianacnguyen merged commit 1565b29 into main Sep 3, 2024
35 checks passed
@brianacnguyen brianacnguyen deleted the theming-fix branch September 3, 2024 17:15
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 3, 2024
@metamaskbot metamaskbot added the release-7.31.0 Issue or pull request that will be included in release 7.31.0 label Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wachunei wachunei wachunei approved these changes

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.31.0 Issue or pull request that will be included in release 7.31.0 team-design-system All issues relating to design system in Mobile
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook does not render dark mode
5 participants
@brianacnguyen @codecov-commenter @wachunei @georgewrmarshall @metamaskbot